Skip to content

REF: remove no-op casting in groupby.generic #41048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2021

Conversation

jbrockmendel
Copy link
Member

Simplify _get_cython_function
Raise TypeError instead of NotImplementedError in cases where we shouldn't bother falling back to py_fallback

@jreback jreback added Groupby Refactor Internal refactoring of code labels Apr 20, 2021
@jreback jreback added this to the 1.3 milestone Apr 20, 2021
@jreback jreback merged commit 059c8ba into pandas-dev:master Apr 20, 2021
@jreback
Copy link
Contributor

jreback commented Apr 20, 2021

great

@jbrockmendel jbrockmendel deleted the ref-gbop-downcast branch April 20, 2021 16:02
yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request Apr 21, 2021
yeshsurya pushed a commit to yeshsurya/pandas that referenced this pull request May 6, 2021
JulianWgs pushed a commit to JulianWgs/pandas that referenced this pull request Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants